Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Knative Social Media Guidelines : https://github.com/knative/community/issues/1444 #1445

Merged
merged 4 commits into from
Jun 4, 2024

Conversation

nainaz
Copy link
Contributor

@nainaz nainaz commented Oct 10, 2023

Fixes #1444

Changes

New markdown for social media guidelines

/kind

Fixes #

Release Note


Docs


@knative-prow
Copy link

knative-prow bot commented Oct 10, 2023

@nainaz: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot requested review from puerco and salaboy October 10, 2023 15:45
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 10, 2023
Copy link
Member

@csantanapr csantanapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make the file .md

Knative Social Media Guidelines.md Outdated Show resolved Hide resolved
Knative Social Media Guidelines.md Outdated Show resolved Hide resolved
Knative Social Media Guidelines.md Outdated Show resolved Hide resolved
Knative Social Media Guidelines.md Outdated Show resolved Hide resolved
Knative Social Media Guidelines.md Outdated Show resolved Hide resolved
Knative Social Media Guidelines.md Outdated Show resolved Hide resolved
Knative Social Media Guidelines.md Outdated Show resolved Hide resolved
Knative Social Media Guidelines.md Outdated Show resolved Hide resolved
@aliok
Copy link
Member

aliok commented Oct 13, 2023

Another thing, could you please rename the file to something like SOCIAL_MEDIA_GUIDELINES.md?
Other files have that kind of pattern.

One last thing, when the PR merges, can you delete the nainaz-patch-1 branch? I know it is a bit confusing, but generally:

  • You work in your own fork
  • Create a branch there
  • Send a PR agains main branch of this repo

Copy link

@sandipanpanda sandipanpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aliok
Copy link
Member

aliok commented Feb 15, 2024

@nainaz now that we want to use social media more often, would you like me to take this PR over?

@nainaz
Copy link
Contributor Author

nainaz commented Feb 17, 2024

Please go ahead

@nainaz
Copy link
Contributor Author

nainaz commented May 16, 2024 via email

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 22, 2024
@aliok
Copy link
Member

aliok commented May 22, 2024

@knative/steering-committee

I've updated the document. Can you review please?

Comment on lines +71 to +73
### Biweekly social media post

After each Knative Steering Committee meeting, we will share a post on Twitter and LinkedIn to share the highlights of the past 2 weeks.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like it might veer into the "announcements" or "news" aspect. Other that that, this LGTM.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2024
Copy link

knative-prow bot commented Jun 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, nainaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [evankanderson,nainaz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit c179083 into main Jun 4, 2024
3 checks passed
@aliok aliok deleted the nainaz-patch-1 branch June 4, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create social media guidelines
5 participants